Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINVOKER-274] upgrade to groovy 3.0.8 #58

Merged
merged 2 commits into from
Aug 8, 2021
Merged

Conversation

olamy
Copy link
Member

@olamy olamy commented Aug 7, 2021

Signed-off-by: Olivier Lamy olamy@apache.org

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Aug 7, 2021
@pzygielo
Copy link
Contributor

pzygielo commented Aug 7, 2021

Could groovy-bom:pom be imported and explicit version in all groovy-* dependencies skipped?

@olamy
Copy link
Member Author

olamy commented Aug 7, 2021

Could groovy-bom:pom be imported and explicit version in all groovy-* dependencies skipped?

not sure how that helps here :)

@pzygielo
Copy link
Contributor

pzygielo commented Aug 7, 2021

IMO, it'd be more maven-way.

@olamy
Copy link
Member Author

olamy commented Aug 7, 2021

bom are useful for multi modules but no real value for a one module project.

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
Copy link
Member Author

olamy commented Aug 8, 2021

I moved to use bom. frankly not really convince it's really useful in this case.... (compared to usage in parent poms) and we do not have any sort of upperbound rule in place

@olamy olamy merged commit 709c6c7 into master Aug 8, 2021
@olamy olamy deleted the MINVOKER-274-groovy-3.0.8 branch August 8, 2021 04:53
@olamy olamy restored the MINVOKER-274-groovy-3.0.8 branch August 9, 2021 00:39
@olamy olamy deleted the MINVOKER-274-groovy-3.0.8 branch August 9, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants